Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device as parameter to TP and rotary_embedding functions #11888

Closed

Conversation

chunyuan-w
Copy link

@chunyuan-w chunyuan-w commented Jan 9, 2025

This PR adds device as parameter to TP and rotary_embedding functions.
For TP functions including get_tensor_model_parallel_world_size, get_tensor_model_parallel_rank and get_tp_group, we add device as parameter to distinguish the behavior between CPU and GPU.
For rotary_embedding, device="cuda" has been hard-coded. We add a device parameter and set the device of tensors accordingly.

Copy link

github-actions bot commented Jan 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@hmellor
Copy link
Member

hmellor commented Apr 5, 2025

@chunyuan-w is this PR still relevant? If not, can we close it? (I'm just doing some housekeeping)

@chunyuan-w
Copy link
Author

It's not relevant anymore

@chunyuan-w chunyuan-w closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants