-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add model_glm code #11883
base: main
Are you sure you want to change the base?
add model_glm code #11883
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
@zhipuch Could you elaborate about the logic issues? Since the hf-format glm model is a llama-style one, I don't think we should copy most of code from |
OK, I revisited the issue and found the main bug now:
|
Oh, my bad, I‘m fine to use |
This pull request has merge conflicts that must be resolved before it can be |
The full glm model code eliminates formatting and logic issues during inference using the inherited llama method.