Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec Decode] Add Script for converting HF Eagle checkpoint to vLLM compatible checkpoint #11866

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sroy745
Copy link
Collaborator

@sroy745 sroy745 commented Jan 8, 2025

  1. Add Script for converting HF Eagle checkpoint to vLLM compatible checkpoint. The script is borrowed from https://gist.github.com/abhigoyal1997/1e7a4109ccb7704fbc67f625e86b2d6d but moving it to the vLLM repo for better source control.
  2. Addressed a previous documentation comment about adding num_speculative_tokens and updating the link of the script added in 1 in our .md docs.

#11126

Signed-off-by: root <Sourashis Roy>
Copy link

github-actions bot commented Jan 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 8, 2025
Signed-off-by: root <Sourashis Roy>
@sroy745 sroy745 changed the title [WIP] Add Spec Decode script [Spec Decode] Add Script for converting HF Eagle checkpoint to vLLM compatible checkpoint Jan 8, 2025
root added 2 commits January 8, 2025 21:32
Signed-off-by: root <Sourashis Roy>
Signed-off-by: root <Sourashis Roy>
@sroy745
Copy link
Collaborator Author

sroy745 commented Jan 8, 2025

@LiuXiaoxuanPKU / @llsj14 PTAL when you get a chance

Copy link
Contributor

@llsj14 llsj14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

'--baseline_ckpt_file_lm_head',
type=str,
help="Path to the baseline model checkpoint file containing the "
"weights for lm_head")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be also nice if you inform the baseline ckpt file should be 'safetensor'. Because in this script, the load_file function is for only safetensors.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the comment.

Signed-off-by: root <Sourashis Roy>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants