Skip to content

[Model] Added Google T5 model support to vLLM #11780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Model] Added Google T5 model support to vLLM #11780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d391c95
add t5 support to vllm
bmullick-amd Jan 6, 2025
7528eff
fixed yapf fails
bmullick-amd Jan 30, 2025
d2cc40a
ran format checker
bmullick-amd Jan 30, 2025
ee78f4b
ran pre commit check
bmullick-amd Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/inputs/preprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def _prepare_decoder_input_ids_for_generation(
if decoder_input_ids is None:
# no decoder prompt input ->
# use decoder_start_token_id as decoder_input_ids
decoder_input_ids = self._get_default_enc_dec_decoder_prompt()
decoder_input_ids = [decoder_start_token_id]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it has something to do with this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Could you provide guidance as to how I can recreate this error locally? Thanks. Currently I am running pytest command but am getting error related to env issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self._get_default_enc_dec_decoder_prompt() returns bos_token_id rather than decoder_start_token_id

@afeldman-nm @robertgshaw2-redhat do you know why that's the case despite the code comments here?


if (len(decoder_input_ids) == 0
or decoder_input_ids[0] != decoder_start_token_id):
Expand Down
3 changes: 3 additions & 0 deletions vllm/model_executor/models/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@
"BartModel": ("bart", "BartForConditionalGeneration"),
"BartForConditionalGeneration": ("bart", "BartForConditionalGeneration"),
"Florence2ForConditionalGeneration": ("florence2", "Florence2ForConditionalGeneration"), # noqa: E501
"T5Model": ("t5", "T5ForConditionalGeneration"),
"T5ForConditionalGeneration": ("t5", "T5ForConditionalGeneration"),
"T5WithLMHeadModel": ("t5", "T5ForConditionalGeneration")
}

_EMBEDDING_MODELS = {
Expand Down
Loading