Skip to content

Enable triangular mask with valid_seq_lengths #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable triangular mask with valid_seq_lengths #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions vllm_gaudi/extension/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,10 +313,6 @@ def _fsdpa_prompt_attention(query: torch.Tensor,
recompute_mode = True
assert attn_bias is not None or valid_seq_lengths is not None, \
'Either attn_bias or valid_seq_lengths must be != None'
if is_causal and attn_bias is not None:
# TODO: causal + attn_bias is not yet supported
is_causal = False
valid_seq_lengths = None
attn_weights = fsdpa_op(query, key, value, attn_bias, 0.0, is_causal, scale, softmax_mode, recompute_mode,
valid_seq_lengths, 'right')
attn_weights = attn_weights.transpose(1, 2)
Expand Down
Loading