Skip to content

update default build values to use versioned builds #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −7
Open

update default build values to use versioned builds #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3b5f3f
update default build values to use versioned builds, fix versioned bu…
DaltheCow Sep 9, 2025
84423a5
Merge branch 'main' into set-default-ui-build-to-versioned-build
DaltheCow Sep 9, 2025
eacc2fa
update tests
DaltheCow Sep 10, 2025
3261327
Merge branch 'set-default-ui-build-to-versioned-build' of github.com:…
DaltheCow Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ jobs:
uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./ui/out
publish_dir: .src/ui/out
destination_dir: ui/release/${TAG}
keep_files: false
user_name: ${{ github.actor }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ jobs:
uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./ui/out
publish_dir: ./src/ui/out
destination_dir: ui/${TAG}
keep_files: false
user_name: ${{ github.actor }}
Expand Down
4 changes: 2 additions & 2 deletions src/guidellm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ class Environment(str, Enum):


ENV_REPORT_MAPPING = {
Environment.PROD: "https://blog.vllm.ai/guidellm/ui/latest/index.html",
Environment.STAGING: "https://blog.vllm.ai/guidellm/ui/release/latest/index.html",
Environment.PROD: "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html",
Environment.STAGING: "https://blog.vllm.ai/guidellm/ui/release/v0.3.0/index.html",
Environment.DEV: "https://blog.vllm.ai/guidellm/ui/dev/index.html",
Environment.LOCAL: "http://localhost:3000/index.html",
}
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def test_default_settings():
assert settings.openai == OpenAISettings()
assert (
settings.report_generation.source
== "https://blog.vllm.ai/guidellm/ui/latest/index.html"
== "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html"
)


Expand Down Expand Up @@ -60,13 +60,13 @@ def test_report_generation_default_source():
settings = Settings(env=Environment.STAGING)
assert (
settings.report_generation.source
== "https://blog.vllm.ai/guidellm/ui/release/latest/index.html"
== "https://blog.vllm.ai/guidellm/ui/release/v0.3.0/index.html"
)

settings = Settings(env=Environment.PROD)
assert (
settings.report_generation.source
== "https://blog.vllm.ai/guidellm/ui/latest/index.html"
== "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html"
)


Expand Down