Sparse attention window size bug fix #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mklasby
force-pushed
the
sparse-attn-hotfix
branch
from
5ac198c to
22de4f3
Compare
Signed-off-by: Mike Lasby <[email protected]>
mklasby
force-pushed
the
sparse-attn-hotfix
branch
from
22de4f3 to
5a93f56
Compare
|
Thanks a lot for cherry-picking this hotfix! @mklasby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked hotfix from #39 originally by @minminsun which includes critical bug fixes for sparse attention kernel window size. Original PR was closed since the files in this fork were synced with upstream. Notably, the dual-chunk attention PR in vLLM requires this fix.