Skip to content

feat(core): devtools config#173

Open
webfansplz wants to merge 2 commits intomainfrom
feat/devtools-config
Open

feat(core): devtools config#173
webfansplz wants to merge 2 commits intomainfrom
feat/devtools-config

Conversation

@webfansplz
Copy link
Member

@webfansplz webfansplz commented Feb 6, 2026

Since Vite 8 beta.13 ships with Vite DevTools (see: vitejs/vite#21331), this PR moves the config to the core repo for better flexibility. We can now drop the Vite type overrides (see: https://github.com/vitejs/devtools/blob/main/packages/kit/src/types/vite-augment.ts#L5) to fix the clientAuth config setting and typecheck CI. /cc @sapphi-red

Copilot AI review requested due to automatic review settings February 6, 2026 00:15
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 6, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/devtools@173
npm i https://pkg.pr.new/@vitejs/devtools-kit@173
npm i https://pkg.pr.new/@vitejs/devtools-rolldown@173
npm i https://pkg.pr.new/@vitejs/devtools-rpc@173

commit: 84f313a

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a DevTools configuration system to the core package, moving configuration handling from the Vite DevTools package. This enables better type safety by avoiding Vite type overrides and allows proper configuration of the clientAuth setting.

Changes:

  • Adds a new isObject utility function for type checking
  • Introduces DevToolsConfig interfaces and a normalization function for handling various config input types
  • Exports the new config types and functions from the core package

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
packages/core/src/node/utils.ts Adds isObject type guard utility function for runtime object detection
packages/core/src/node/config.ts Defines DevToolsConfig interfaces and normalizeDevToolsConfig function to handle config normalization
packages/core/src/index.ts Exports the new config types and functions from the package

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@webfansplz webfansplz force-pushed the feat/devtools-config branch from 43464a6 to c01e3fb Compare February 6, 2026 00:39
@webfansplz webfansplz force-pushed the feat/devtools-config branch from c01e3fb to 84f313a Compare February 6, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant