Allow reconfiguring Faraday with block and explain NTLM auth. #68
+51
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm so sorry that I missed this pull request. Great job! The one thing I'd like to see is some specs testing out NTLM auth. I love the README addition, that will help a lot of users. I plan on rolling out a new version and would like to add this. Do you have time to add some specs? |
|
I pulled your changes in the develop branch, but a bunch of specs failed. I didn't check anything into GitHub. Could you revisit the changes against the develop branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the OData Service to allow passing it a block that is called when Faraday is initialised. This allows more advanced configurations such as NTLM auth, of which I give an example in the README. (Since NTLM auth with Faraday is undocumented, my way of using it might not be the best. Therefore, this code is kept outside the OData library, so other ways of reconfiguring Faraday are also possible.)