gofumpt code

[thaJeztah]

No description provided.

[adrianchiris]

great initiative,

This should ideally come with a github workflow which will ensure the project remains gofumpted.

[thaJeztah]

great initiative,

This should ideally come with a github workflow which will ensure the project remains gofumpted.

Yes, it would be good to set up a linter in this repo; I see #859 gave this a try, but was closed.

I just ran golangci-lint with its default options on this repo, and there's a lot of things it's flagging (not all critical), but probably better to keep separate from this PR.

At least this PR should set a baseline for formatting, and we can do some periodic updates to fix regressions in that area (until a linter is in place).

I rebased this PR, and should be ready for review again. 🙏

[aojea]

LGTM

[thaJeztah]

This should ideally come with a github workflow which will ensure the project remains gofumpted.

☝️ short update on that effort; I also opened a PR to fix most (not all) linting issues with the default golangci-lint settings; #1048. There are still some linting issues to address after that one that may need some eyes (either fix or suppress), after which I can add a golangci-lint action to this repository.

[thaJeztah]

@aboch PTAL 🙏 (this one helps a lot with people having their editor configured to gofmt on save)

[thaJeztah]

@aboch PTAL 🙏