Skip to content

fix(9.1): Minor fixes to unblock WebGPU in deck.gl #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 17, 2025
Merged

fix(9.1): Minor fixes to unblock WebGPU in deck.gl #2335

merged 5 commits into from
Feb 17, 2025

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Feb 16, 2025 •
edited
Loading

For #

Background

Change List

  • Prevent crash on attribute format inference
  • Prevent constant attribute error from throwing
  • Avoid relying on WebGLRenderingContext in getDrawingBufferSize (temporary, this is completely refactored in luma 9.2)

@ibgreen ibgreen requested a review from felixpalmer February 16, 2025 15:25
@ibgreen ibgreen changed the title fix: Minor fixes to unblock WebGPU in deck.gl fix(9.1): Minor fixes to unblock WebGPU in deck.gl Feb 16, 2025
@ibgreen ibgreen mentioned this pull request Feb 17, 2025
Merged
@ibgreen ibgreen merged commit 4a994a4 into 9.1-release Feb 17, 2025
1 check passed
@ibgreen ibgreen deleted the ib/wgpu-fixes branch February 17, 2025 15:32
@ibgreen ibgreen mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibgreen @felixpalmer