Skip to content

fix(carto): RasterTileLayer fix to support external loadOptions #9561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

zbigg
Copy link
Collaborator

@zbigg zbigg commented Apr 2, 2025

RasterTileLayer requires specific properties (metadata) passed to loader.
Passing custom loadOptions as props, overrides loadOptions.cartoRasterTile.metadata and layer loader always fail to parse tile.

Change List

  • Carto: RasterTileLayer fix support for external loadOptions

@zbigg zbigg requested review from donmccurdy and felixpalmer April 2, 2025 10:16
@zbigg zbigg changed the title fix(carto): RasterTileLayer to support external options fix(carto): RasterTileLayer fix to support external loadOptions Apr 2, 2025
@zbigg zbigg marked this pull request as ready for review April 2, 2025 11:04
@coveralls
Copy link

coveralls commented Apr 2, 2025

Coverage Status

coverage: 91.552%. remained the same
when pulling 8e14a34 on zbigg/carto-raster-tile-loader-loadOptions-fix
into e4891a2 on master.

@zbigg zbigg force-pushed the zbigg/carto-raster-tile-loader-loadOptions-fix branch from 6407e25 to 113b507 Compare April 7, 2025 17:20
@zbigg zbigg force-pushed the zbigg/carto-raster-tile-loader-loadOptions-fix branch from 113b507 to 8e14a34 Compare April 14, 2025 09:24
@zbigg zbigg merged commit 293c3f5 into master Apr 14, 2025
2 checks passed
@zbigg zbigg deleted the zbigg/carto-raster-tile-loader-loadOptions-fix branch April 14, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants