Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: startn default bug #87

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

EdLeckert
Copy link
Collaborator

Fix to issue where changing from Repeating to Fixed Additional Start Times made all additional times active at midnight.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afadaa4) 70.61% compared to head (4bb8e64) 70.61%.
Report is 2 commits behind head on master.

❗ Current head 4bb8e64 differs from pull request most recent head b03b2f2. Consider uploading reports for the commit b03b2f2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files           4        4           
  Lines         980      980           
=======================================
  Hits          692      692           
  Misses        288      288           
Files Coverage Δ
pyopensprinkler/program.py 81.18% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdLeckert EdLeckert force-pushed the feat-support-repeating-start-times branch from e849172 to b03b2f2 Compare November 8, 2023 16:16
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vinteo vinteo merged commit 994487f into vinteo:master Nov 8, 2023
10 checks passed
@EdLeckert EdLeckert deleted the feat-support-repeating-start-times branch November 11, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants