Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-support-repeating-start-times #86

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

EdLeckert
Copy link
Collaborator

Feature to support the Repeating type of Additional Start Times in OpenSprinkler. Sets and gets the Repeat Count and Repeat Interval.

Also clears out start1-3 when changing types, as these values hold different types of information depending on the setting of Fixed vs. Repeating.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8edd0bf) 70.14% compared to head (afadaa4) 70.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   70.14%   70.61%   +0.46%     
==========================================
  Files           4        4              
  Lines         958      980      +22     
==========================================
+ Hits          672      692      +20     
- Misses        286      288       +2     
Files Coverage Δ
pyopensprinkler/program.py 81.18% <91.30%> (+0.80%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdLeckert EdLeckert force-pushed the feat-support-repeating-start-times branch from 3b21a53 to afadaa4 Compare November 7, 2023 16:50
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vinteo vinteo merged commit ed0c0c0 into vinteo:master Nov 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants