Fix export image with background issue #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #137 Update `loadImage` function to remove the `crossorigin` attribute in `packages/react-sketch-canvas/src/Canvas/index.tsx`. Modify `exportImage` function to handle protected URLs requiring cookies and ensure the background image is fully included in the exported image. Add test cases in `packages/tests/src/actions/export.spec.tsx`: * Verify the exported image includes the entire background image correctly. * Verify the exported image does not include the 'NA' symbol. * Verify the issue is resolved for both public and protected URLs. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/vinothpandian/react-sketch-canvas/issues/137?shareId=XXXX-XXXX-XXXX-XXXX).
vinothpandian
force-pushed
the
fix-export-image
branch
from
7c52c1b to
f0b25c2
Compare
|
Copilot workspace did a bad job here. I'm going to close it and try again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
Update
loadImagefunction to remove thecrossoriginattribute inpackages/react-sketch-canvas/src/Canvas/index.tsx.Modify
exportImagefunction to handle protected URLs requiring cookies and ensure the background image is fully included in the exported image.Add test cases in
packages/tests/src/actions/export.spec.tsx:For more details, open the Copilot Workspace session.