Skip to content

Commit

Permalink
Fix issues raised in review
Browse files Browse the repository at this point in the history
  • Loading branch information
vimuthm committed Oct 7, 2021
1 parent e0e3cb4 commit 67a69d0
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/SettingUp.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ If you plan to use Intellij IDEA (highly recommended):
1. **Import the project as a Gradle project**: Follow the guide [_[se-edu/guides] IDEA: Importing a Gradle project_](https://se-education.org/guides/tutorials/intellijImportGradleProject.html) to import the project into IDEA.<br>
:exclamation: Note: Importing a Gradle project is slightly different from importing a normal Java project.
1. **Verify the setup**:
1. Run the `Main` and try a few commands.
1. Run the `safeforhall.Main` and try a few commands.
1. [Run the tests](Testing.md) to ensure they all pass.

--------------------------------------------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion docs/Testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ There are two ways to run tests.
This project has three types of tests:

1. *Unit tests* targeting the lowest level methods/classes.<br>
e.g. `seedu.address.commons.StringUtilTest`
e.g. `safeforhall.commons.StringUtilTest`
1. *Integration tests* that are checking the integration of multiple code units (those code units are assumed to be working).<br>
e.g. `StorageManagerTest`
1. Hybrids of unit and integration tests. These test are checking multiple code units as well as how the are connected together.<br>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/safeforhall/MainApp.java
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public void start(Stage primaryStage) {

@Override
public void stop() {
logger.info("============================ [ Stopping Address Book ] =============================");
logger.info("============================ [ Stopping SafeFor(H)All ] =============================");
try {
storage.saveUserPrefs(model.getUserPrefs());
} catch (IOException e) {
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/safeforhall/model/person/Person.java
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@ public String toString() {
.append("; Email: ")
.append(getEmail())
.append("; Vaccinated: ")
.append(getVaccStatus());
.append(getVaccStatus())
.append("; Faculty: ")
.append(getFaculty());

return builder.toString();
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/safeforhall/logic/commands/CommandTestUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ public class CommandTestUtil {
static {
DESC_AMY = new EditPersonDescriptorBuilder().withName(VALID_NAME_AMY)
.withPhone(VALID_PHONE_AMY).withEmail(VALID_EMAIL_AMY)
.withTags(VALID_TAG_FRIEND).build();
.build();
DESC_BOB = new EditPersonDescriptorBuilder().withName(VALID_NAME_BOB)
.withPhone(VALID_PHONE_BOB).withEmail(VALID_EMAIL_BOB)
.withTags(VALID_TAG_HUSBAND, VALID_TAG_FRIEND).build();
.build();
}

/**
Expand Down
1 change: 1 addition & 0 deletions src/test/java/safeforhall/model/AddressBookTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public void resetData_withValidReadOnlyAddressBook_replacesData() {
assertEquals(newData, addressBook);
}

// TODO: Fix testcase
@Test
public void resetData_withDuplicatePersons_throwsDuplicatePersonException() {
// Two persons with the same identity fields
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import safeforhall.model.person.Name;
import safeforhall.model.person.Phone;

// TODO: Add all test cases for new fields
public class JsonAdaptedPersonTest {
private static final String INVALID_NAME = "R@chel";
private static final String INVALID_PHONE = "+651234";
Expand Down

0 comments on commit 67a69d0

Please sign in to comment.