Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usr_01.{txt|jax} #744

Merged
merged 4 commits into from
Dec 16, 2019
Merged

Update usr_01.{txt|jax} #744

merged 4 commits into from
Dec 16, 2019

Conversation

chaspy
Copy link
Contributor

@chaspy chaspy commented Dec 14, 2019 •
edited
Loading

ref: #608 (comment)
No need to update usr_01.jax 😉

Please review and merge 🙏

@chaspy chaspy changed the title [WIP]Update usr_01.txt Update usr_01.txt Dec 14, 2019
get-me-power
get-me-power reviewed Dec 15, 2019
View reviewed changes
Copy link
Member

@get-me-power get-me-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.jaxファイルの一番上の日付は更新したほうがいいと思いました。
@h-east @k-takata
どう思いますか？

get-me-power
get-me-power reviewed Dec 15, 2019
View reviewed changes
Copy link
Member

@get-me-power get-me-power left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

それ以外はLGTMです

@h-east
Copy link
Member

h-east commented Dec 16, 2019

.jaxファイルの一番上の日付は更新したほうがいいと思いました。

確かに。
@chaspy 対応お願いします。

@chaspy chaspy changed the title Update usr_01.txt Update usr_01.{txt|jax} Dec 16, 2019
@chaspy
Copy link
Contributor Author

chaspy commented Dec 16, 2019

Addressed 9324f78
Ready for review again 👍

h-east
h-east reviewed Dec 16, 2019
View reviewed changes
en/usr_01.txt Outdated
@@ -1,4 +1,4 @@
*usr_01.txt* For Vim version 8.1. Last change: 2017 Jul 15
*usr_01.txt* For Vim version 8.1. Last change: 2019 Nov 21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/8.1/8.2/

doc/usr_01.jax Outdated
@@ -1,4 +1,4 @@
*usr_01.txt* For Vim バージョン 8.1. Last change: 2017 Jul 15
*usr_01.txt* For Vim バージョン 8.1. Last change: 2019 Nov 21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/8.1/8.2/

chaspy
chaspy commented Dec 16, 2019
View reviewed changes
chaspy
chaspy commented Dec 16, 2019
View reviewed changes
@k-takata k-takata merged commit 54e67ec into vim-jp:master Dec 16, 2019
@k-takata
Copy link
Member

ありがとうございます。

@chaspy chaspy deleted the chaspy/update-usr-1-doc branch December 16, 2019 01:30
@get-me-power
Copy link
Member

@chaspy
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-east h-east h-east approved these changes

@get-me-power get-me-power get-me-power approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaspy @h-east @k-takata @get-me-power