New theme: Corner layout #40
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| // Base styles | ||
| html.easy-popup-open { | ||
| &:has(.easy-popup-master-corner.open) { | ||
| .easy-popup-master { | ||
| opacity: 0; | ||
| visibility: hidden; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .easy-popup-master-corner { | ||
| transition: opacity 0.4s ease, transform 0.4s ease; | ||
| transform: translateX(0); | ||
| position: fixed; | ||
| bottom: 0; | ||
| right: 0; | ||
| max-width: 450px; | ||
|
There was a problem hiding this comment. Please note that we are using the library for multiple purposes. So make it as flexible as you can, the |
||
| opacity: 1; | ||
| visibility: visible; | ||
| top: unset; | ||
| left: unset; | ||
| height: unset; | ||
| width: unset; | ||
| display: block; | ||
|
|
||
| &:not(.open) { | ||
| pointer-events: none; | ||
| } | ||
|
|
||
| .ep-close-button { | ||
| position: fixed; | ||
| transform: translate(0); | ||
| --ep-close-color: #000; | ||
|
There was a problem hiding this comment. Why do you override this variable here? CSS override should use the same selector when possible. |
||
| } | ||
|
|
||
| .easy-popup-overflow { | ||
| overflow: unset; | ||
| } | ||
|
|
||
| .easy-popup-container { | ||
| padding: 0; | ||
|
|
||
| .easy-popup-inner { | ||
| box-shadow: 0 0 10px 0 rgba(0, 0, 0, 0.1); | ||
| border-radius: var(--ep-radius); | ||
| overflow: hidden; | ||
| max-height: calc(100vh - (var(--ep-corner-offset) * 2)); | ||
| overflow-y: auto; | ||
| } | ||
| } | ||
|
|
||
| // Position variants | ||
|
There was a problem hiding this comment. Why do some positions have all top left bottom right properties, while some do not? |
||
| &.top-left { | ||
| top: var(--ep-corner-offset); | ||
| left: var(--ep-corner-offset); | ||
| bottom: unset; | ||
| right: unset; | ||
| } | ||
|
|
||
| &.top-right { | ||
| top: var(--ep-corner-offset); | ||
| right: var(--ep-corner-offset); | ||
| bottom: unset; | ||
| } | ||
|
|
||
| &.bottom-left { | ||
| bottom: var(--ep-corner-offset); | ||
| left: var(--ep-corner-offset); | ||
| right: unset; | ||
| } | ||
|
|
||
| &.bottom-right { | ||
| bottom: var(--ep-corner-offset); | ||
| right: var(--ep-corner-offset); | ||
| } | ||
|
|
||
| @media only screen and (max-width: 768px) { | ||
|
There was a problem hiding this comment. Should this breakpoint be consistent with the mobile layout here easy-popup/src/css/layout-mobile.scss Line 16 in dd83fa3 |
||
| --ep-corner-offset: 0px; | ||
| --ep-padding: 15px; | ||
| padding: var(--ep-padding); | ||
|
|
||
| .ep-close-button { | ||
| top: var(--ep-padding); | ||
|
There was a problem hiding this comment. Do you know the purpose of |
||
| right: var(--ep-padding); | ||
| } | ||
|
|
||
| .easy-popup-container .easy-popup-inner { | ||
| max-height: calc(100vh - (var(--ep-padding) * 2)); | ||
| } | ||
| } | ||
|
|
||
| // Slide animations | ||
| &[class*="right"]:not(.open) { | ||
|
There was a problem hiding this comment.
|
||
| transform: translateX(100%); | ||
| } | ||
|
|
||
| &[class*="left"]:not(.open) { | ||
| transform: translateX(-100%); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to hide
.easy-popup-masterhere?