AI update based on proto changes #953
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
gabegottlob
reviewed
Jul 16, 2025
| @@ -455,7 +455,7 @@ async def tabular_data_by_filter( | |||
| if dest: | |||
| try: | |||
| file = open(dest, "w") | |||
| file.write(f"{[str(d) for d in data]}") | |||
| file.write(f"{[[str(d) for d in data]}") | |||
gabegottlob
reviewed
Jul 16, 2025
| @@ -760,7 +760,7 @@ async def binary_data_by_filter( | |||
| if dest: | |||
| try: | |||
| file = open(dest, "w") | |||
| file.write(f"{[str(d) for d in data]}") | |||
| file.write(f"{response.data}") | |||
gabegottlob
reviewed
Jul 16, 2025
| 'readings': { | ||
| 'linear_velocity': {'x': 0.5, 'y': 0.0, 'z': 0.0}, | ||
| 'angular_velocity': {'x': 0.0, 'y': 0.0, 'z': 0.1} | ||
| tabular_data=[ |
There was a problem hiding this comment.
AI hallucinated and edited this comment for some reason
|
side note: we should ultimately change the token used for running this AI update job so that viambot runs it rather than github-actions. This will allow for tests to run automatically on a new PR so we can more reliably catch AI hallucination. |
|
@stuqdog will do. Also i am working on a workaround to get rid of the random hallucinations that happens when the AI generates the new files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an AI-generated PR to update the SDK based on proto changes. The AI may make mistakes so review carefully.