[RSDK-10139] Implement User-defined Metadata Methods #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JosephBorodach @edobranov I tagged both of you guys just because I know you both worked on the other SDK's. Feel free to remove yourself. |
|
Going to remove myself for now so I stop getting notifications, but feel free to re-add me when it's ready for review again |
njooma
approved these changes
May 1, 2025
| metadata (Mapping[str, Any]): The user-defined metadata to upload as a Python dictionary. | ||
| """ | ||
| request = UpdateOrganizationMetadataRequest(organization_id=org_id, data=dict_to_struct(metadata)) | ||
| _: UpdateOrganizationMetadataResponse = await self._app_client.UpdateOrganizationMetadata(request) |
There was a problem hiding this comment.
You can leave out all these return type since they're unused
edobranov
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket
This PR implements the
getandupdatemethods for user-defined metadata on all four resource types (organizations, locations, robots, and robot parts). Also included in this PR are the implementation of these endpoints in the PythonMockAppserver and the addition of unit tests for new SDK methods added. The unit tests all first attempt togetmetadata on a resource, assert that the returned dictionary is empty (as is the expected behavior here), and then proceed toupdateactual metadata that gets retrieved and asserted again. The mock endpoints pretty much exactly mimic the behavior of these endpoints in our actual App server.