Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/motion-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
run: |
cd motion-testing
go mod edit -replace go.viam.com/rdk=${URL#"https://"}@$SHA
sudo -Hu testbot bash -lc "go mod tidy && go test ./... -v -run TestDefault --name=$BASELINE"
sudo -Hu testbot bash -lc "go mod tidy && go test ./... -run TestDefault --name=$BASELINE"

- name: Run motion quality tests on PR branch
shell: bash
Expand All @@ -51,7 +51,7 @@ jobs:
run: |
cd motion-testing
go mod edit -replace go.viam.com/rdk=${URL#"https://"}@$SHA
sudo -Hu testbot bash -lc "go mod tidy && go test ./... -v -run TestDefault --name=$MODIFIED"
sudo -Hu testbot bash -lc "go mod tidy && go test ./... -run TestDefault --name=$MODIFIED"

- name: Print results
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:
--platform linux/arm/v7 \
-v `pwd`:/rdk \
ghcr.io/viamrobotics/rdk-devenv:armhf-cache \
sudo -Hu testbot bash -lc 'sudo apt-get update && sudo apt-get install -y python3-venv && cd /rdk && go test -v ./...'
sudo -Hu testbot bash -lc 'sudo apt-get update && sudo apt-get install -y python3-venv && cd /rdk && go test ./...'

motion_tests:
name: Test Longer-running Motion Plans if affected
Expand Down
2 changes: 1 addition & 1 deletion components/gantry/fake/gantry.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ func (g *Gantry) Kinematics(ctx context.Context) (referenceframe.Model, error) {
if err != nil {
return nil, err
}
m.OrdTransforms = append(m.OrdTransforms, f)
m.SetOrdTransforms(append(m.OrdTransforms(), f))
return m, nil
}

Expand Down
2 changes: 1 addition & 1 deletion components/gantry/multiaxis/multiaxis.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func (g *multiAxis) Kinematics(ctx context.Context) (referenceframe.Model, error
if err != nil {
return nil, err
}
model.OrdTransforms = append(model.OrdTransforms, k)
model.SetOrdTransforms(append(model.OrdTransforms(), k))
}
g.model = model
}
Expand Down
4 changes: 2 additions & 2 deletions components/gantry/singleaxis/singleaxis.go
Original file line number Diff line number Diff line change
Expand Up @@ -608,14 +608,14 @@ func (g *singleAxis) Kinematics(ctx context.Context) (referenceframe.Model, erro
if err != nil {
return nil, err
}
m.OrdTransforms = append(m.OrdTransforms, f)
m.SetOrdTransforms(append(m.OrdTransforms(), f))

f, err = referenceframe.NewTranslationalFrame(g.Name().ShortName(), g.frame, referenceframe.Limit{Min: 0, Max: g.lengthMm})
if err != nil {
return nil, err
}

m.OrdTransforms = append(m.OrdTransforms, f)
m.SetOrdTransforms(append(m.OrdTransforms(), f))
g.model = m
}
return g.model, nil
Expand Down
Loading
Loading