Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3489: Add windows to setup page #3959

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Jan 31, 2025

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 31, 2025
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit c20e595
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67a2325e51062100084eb58b
😎 Deploy Preview https://deploy-preview-3959--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 33 (🟢 up 11 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@npentrel npentrel requested a review from abe-winter January 31, 2025 23:58
@@ -40,6 +40,9 @@ Viam can run on any computer that runs one of the following operating systems:

- Linux 64-bit operating systems running on AArch64 (ARM64) or x86-64 architectures
- macOS
- Windows
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abe-winter I think this is all that's needed unless you want anything else covered?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes lgtm -- I think we will update this guidance as folks play around with windows support, but this feels like the answer today afaik

@@ -40,6 +40,9 @@ Viam can run on any computer that runs one of the following operating systems:

- Linux 64-bit operating systems running on AArch64 (ARM64) or x86-64 architectures
- macOS
- Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes lgtm -- I think we will update this guidance as folks play around with windows support, but this feels like the answer today afaik

@npentrel npentrel merged commit 8246474 into viamrobotics:main Feb 5, 2025
12 checks passed
@npentrel npentrel deleted the DOCS-3489 branch February 5, 2025 13:32
Copy link

github-actions bot commented Feb 5, 2025

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants