Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3471: Update camera.md remove stream from Go camera interface #3942

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

sguequierre
Copy link
Contributor

  • API has already been removed but thought this needed to go? double checking with sean

* API has already been removed but thought this needed to go? double checking with sean
@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 29, 2025
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit b18f7c5
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/679d0bf89627a00008777ef1
😎 Deploy Preview https://deploy-preview-3942--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🟢 up 9 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sguequierre sguequierre requested a review from hexbabe January 29, 2025 19:56
Copy link
Member

@hexbabe hexbabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Are there any other docs changes that mention Stream and Stream.Next to get image?

@sguequierre
Copy link
Contributor Author

Nice! Are there any other docs changes that mention Stream and Stream.Next to get image?

there are a few more, going through now-- thanks for reminding me! I had already changed on the vision and camera APIs but looking now there are a few more instances where this is used.

Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I'm curious how the video feed on a camera test panel works and if we want to elude to that?

@sguequierre
Copy link
Contributor Author

LGTM though I'm curious how the video feed on a camera test panel works and if we want to elude to that?

it seems to function just the same as before, although I am unsure how exactly it works. @hexbabe do you think we need to add any additional information here and if so what would it be?

@hexbabe
Copy link
Member

hexbabe commented Jan 30, 2025

LGTM though I'm curious how the video feed on a camera test panel works and if we want to elude to that?

it seems to function just the same as before, although I am unsure how exactly it works. @hexbabe do you think we need to add any additional information here and if so what would it be?

I think behavior on app should be exactly the same as before. If it isn't then it's a bug

@JessamyT
Copy link
Collaborator

What I mean is that, if it's possible to stream video from a camera, should we be telling people how so they don't think they can only get static images and not video?

@hexbabe
Copy link
Member

hexbabe commented Jan 30, 2025

What I mean is that, if it's possible to stream video from a camera, should we be telling people how so they don't think they can only get static images and not video?

In the context of this doc change PR, it is not possible to stream video from a camera using the camera interface API itself in any SDK besides TS and Flutter

@hexbabe
Copy link
Member

hexbabe commented Jan 30, 2025

The now-removed Golang Stream is a bit of a misnomer which is a big reason why it was removed. TS and Flutter use RenderFrame, AddStream (which is not camera API) and some webrtc magic to achieve true streams.

@hexbabe
Copy link
Member

hexbabe commented Jan 30, 2025

Sorry I think I'm being unclear. For the camera component docs, I don't think we should mention streaming because streaming cannot be achieved with just camera API methods.

@JessamyT
Copy link
Collaborator

Ooh ty for the explanation

@sguequierre sguequierre merged commit d8c1d64 into main Jan 31, 2025
13 checks passed
@sguequierre sguequierre deleted the sguequierre-patch-2 branch January 31, 2025 22:40
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants