-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-3471: Update camera.md remove stream from Go camera interface #3942
Conversation
sguequierre
commented
Jan 29, 2025
- API has already been removed but thought this needed to go? double checking with sean
* API has already been removed but thought this needed to go? double checking with sean
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Are there any other docs changes that mention Stream and Stream.Next to get image?
there are a few more, going through now-- thanks for reminding me! I had already changed on the vision and camera APIs but looking now there are a few more instances where this is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I'm curious how the video feed on a camera test panel works and if we want to elude to that?
it seems to function just the same as before, although I am unsure how exactly it works. @hexbabe do you think we need to add any additional information here and if so what would it be? |
I think behavior on app should be exactly the same as before. If it isn't then it's a bug |
What I mean is that, if it's possible to stream video from a camera, should we be telling people how so they don't think they can only get static images and not video? |
In the context of this doc change PR, it is not possible to stream video from a camera using the camera interface API itself in any SDK besides TS and Flutter |
The now-removed Golang |
Sorry I think I'm being unclear. For the camera component docs, I don't think we should mention streaming because streaming cannot be achieved with just camera API methods. |
Ooh ty for the explanation |
🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)' |