Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3466: Remove stream from hello world module guide #3935

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

JessamyT
Copy link
Collaborator

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 28, 2025
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 67c6b63
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67990a114aaba500086d2a1a
😎 Deploy Preview https://deploy-preview-3935--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 21 (🔴 down 9 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sguequierre sguequierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very rusty on modules but you might need to add Image now that that's been added to the interface?

@JessamyT
Copy link
Collaborator Author

See lines above; image is implemented in the previous step. The diff in this case is just what isn't implemented.

@JessamyT JessamyT requested a review from sguequierre January 28, 2025 17:37
@sguequierre
Copy link
Collaborator

See lines above; image is implemented in the previous step. The diff in this case is just what isn't implemented.

oh sorry I assumed it would be in the same step. should have checked more carefully.

@JessamyT
Copy link
Collaborator Author

See lines above; image is implemented in the previous step. The diff in this case is just what isn't implemented.

oh sorry I assumed it would be in the same step. should have checked more carefully.

No worries--would rather you mention it than risk image falling through the cracks completely!

@JessamyT JessamyT merged commit 1393154 into main Jan 28, 2025
14 checks passed
@JessamyT JessamyT deleted the JessamyT-patch-2 branch January 28, 2025 18:13
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants