DEV-2212 Fix except order RequestExceptions#47
Open
AaronVr wants to merge 1 commit into
Open
Conversation
Switched order of except branches for `RequestException` and `HTTPError`. This is necessary to ensure that the `HTTPError` branch is actually reachable, as `HTTPError` is a subtype of `RequestException`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in our try-blocks
RequestExceptionis checked beforeHTTPError. This means that theHTTPErrorexcept branch can never be reached, asHTTPErroris a subtype ofRequestException. The order of the branches needs to be switched around in order for the application to actually handleHTTPErrors.This bug occurs in the following locations (
main.py):handle_create_event(lines 258–270, 300–312, 346–359)delete_media_object(lines 431–443)handle_remove_event(lines 483–495, 532–544)