DEV-1575 Link subtitles to item#29
Open
WardMaes wants to merge 1 commit into
Open
Conversation
Don't assume the first item is the correct one; `Administrative.Type` should be `videofragment` or `audiofragment`.
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
RudolfDG
approved these changes
Apr 8, 2021
spacid
approved these changes
Apr 14, 2021
Collaborator
spacid
left a comment
spacid
left a comment
There was a problem hiding this comment.
Would filtering via extra query parameter(s) also work? Like and (IsFragment:1).
Even better would be: and (Type:"audiofragment" or Type:"videofragment"). The and (IsFragment:1) check should be redundant here. But not easy doable given the current code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't assume the first item is the correct one;
Administrative.Typeshould bevideofragmentoraudiofragment.