feat: add herbruikbaarheid filter support in elasticsearch query builder #646
Open
RobbeBierebeeck wants to merge 3 commits into
Open
feat: add herbruikbaarheid filter support in elasticsearch query builder #646RobbeBierebeeck wants to merge 3 commits into
RobbeBierebeeck wants to merge 3 commits into
Conversation
bertyhell
approved these changes
Apr 30, 2026
| CONSULTABLE_ONLY_ON_LOCATION = 'isConsultableOnlyOnLocation', | ||
| CONSULTABLE_MEDIA = 'isConsultableMedia', | ||
| CONSULTABLE_PUBLIC_DOMAIN = 'isConsultablePublicDomain', | ||
| REUSABILITY = 'herbruikbaarheid', |
Contributor
There was a problem hiding this comment.
prefer english
Suggested change
| REUSABILITY = 'herbruikbaarheid', | |
| REUSABILITY = 'reusability', |
Comment on lines
+203
to
+221
| export const REUSABILITY_CATEGORY_URIS: Record<string, string[]> = { | ||
| 'vrij-herbruikbaar': [ | ||
| 'https://creativecommons.org/public-domain/pdm/', | ||
| 'https://creativecommons.org/publicdomain/zero/1.0/', | ||
| ], | ||
| 'herbruikbaar-onder-voorwaarden': [ | ||
| 'https://rightsstatements.org/page/NoC-CR/1.0/', | ||
| 'https://creativecommons.org/licenses/by/4.0/', | ||
| 'https://creativecommons.org/licenses/by-nc-nd/4.0/', | ||
| 'https://creativecommons.org/licenses/by-sa/4.0/', | ||
| 'https://creativecommons.org/licenses/by-nc/4.0/', | ||
| ], | ||
| 'misschien-herbruikbaar': [ | ||
| 'https://rightsstatements.org/page/UND/1.0/', | ||
| 'https://rightsstatements.org/page/InC/1.0/', | ||
| 'https://rightsstatements.org/page/CNE/1.0/', | ||
| 'https://rightsstatements.org/page/InC-OW-EU/1.0/', | ||
| 'https://rightsstatements.org/page/InC-RUU/1.0/', | ||
| ], |
Contributor
There was a problem hiding this comment.
prefer enum for categories, and use either the exact values from the database
eg:
- Vrij herbruikbaar
- Herbruikbaar onder voorwaarden
- Misschien herbruikbaar
, or english values for the enum + translate table for the database values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.