feat: use AbortController, fix multipart boundary #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevaum
reviewed
Jan 26, 2023
Comment on lines
+121
to
+128
| // Fix bug https://stackoverflow.com/questions/39280438/fetch-missing-boundary-in-multipart-form-data-post | ||
| if (config.data instanceof FormData && config.headers) { | ||
| const ContentType = 'Content-Type'; | ||
| delete config.headers[ContentType]; | ||
| delete config.headers[ContentType.toLowerCase()]; | ||
| delete config.headers[ContentType.toUpperCase()]; | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't need this. There's code to do it later in the code. Your use case seems similar to mine, which is run axios on a ServiceWorker. I think we just need to fix the condition in the code a little bit below to make sure it enters there. It's not entering the if condition in case of ServiceWorkers because isStandardBrowserEnv is returning false as ServiceWorkers don't have access to window nor document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch with FormData problem:
https://stackoverflow.com/questions/39280438/fetch-missing-boundary-in-multipart-form-data-post