Skip to content

refs #54: add tests for TIMESTAMP WITH TIME ZONE #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: issues/issue-53
Choose a base branch
from

Conversation

KengoTODA
Copy link

To ensure that we can use getInstant(int) if we use TIMESTAMP WITH TIME ZONE.

@Narigo
Copy link
Contributor

Narigo commented Aug 4, 2016

Hi @KengoTODA - sorry for the late response in the bug report. Can you rebase the test against the latest master (incorporating the fix by @pmlopes)? I'd be happy to merge this test. If you want to make it even better, try to move it into SQLTestBase so both PostgreSQL and MySQL check this property. But I can do that afterwards, if you want :)
Thanks!

@KengoTODA
Copy link
Author

@Narigo Thanks for your comment! I tried but I found that WITH TIME ZONE is invalid for MySQL.
Can I keep this test in PostgreSQLTest? Then I'll solve conflict later.

testInstantWithTimeZone(io.vertx.ext.asyncsql.MySQLClientTest)  Time elapsed: 0.017 sec  <<< ERROR!
com.github.mauricio.async.db.mysql.exceptions.MySQLException: Error 1064 - #42000 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'TIME ZONE)' at line 1
    at com.github.mauricio.async.db.mysql.MySQLConnection.onError(MySQLConnection.scala:126)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants