RR Graph / Architecture Pin Side Consistency Check #3268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
libarchfpga
vaughnbetz
reviewed
Sep 9, 2025
There was a problem hiding this comment.
What is the node_sides vector used for? It seems like a heavyweight data structure -- a vector of sides for every node in the rr_graph? Is it alive throughout the rr-graph lifetime or just during building?
It could be stored more compactly as a bit vector (pack in all the sides that are used). I'm also not sure it really deserves to be around at all, as most code doesn't need to check the side of a node. Could be flyweighted too.
| rr_graph_sides = rr_graph.node_sides(rr_node); | ||
| std::tie(std::ignore, std::ignore, arch_side_vec) = get_pin_coordinates(type, ptc_num, std::vector<e_side>(TOTAL_2D_SIDES.begin(), TOTAL_2D_SIDES.end())); | ||
| // Number of sides in arch_side_vec may be higher than rr_graph sides since there may be duplicates (a pin may have different x/y offset on the same side) | ||
| // Because of that, we itearte over arch_side_vec and check if the side is in rr_graph_sides |
|
@vaughnbetz: The side for each node is already stored in a bit vector format in t_rr_node_data. The function I just added creates a vector on demand, which is only used during checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a check to the RR Graph node validation to raise an error if the pin sides stored in the RR Graph don’t correspond to the architecture file.