Skip to content

[web-shared] Move error card to bottom of detail panel #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mitul-s wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −6
Open

[web-shared] Move error card to bottom of detail panel #2337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c543b8
[web-shared] Move error card to bottom of detail panel
mitul-s Jun 10, 2026
a43fb7c
Merge branch 'main' into ms/error-card-placement
mitul-s Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions packages/web-shared/src/components/sidebar/attribute-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,13 +259,13 @@ const attributeOrder: AttributeKey[] = [
'completedAt',
'expiredAt',
'retryAfter',
'error',
'metadata',
'eventData',
'input',
'output',
'attributes',
'resumeAt',
'error',
];

const sortByAttributeOrder = (a: string, b: string): number => {
Expand Down Expand Up @@ -373,6 +373,8 @@ const timestampWithTooltipOrNull = (value: unknown): ReactNode | null => {

interface DisplayContext {
stepName?: string;
resource?: string;
status?: string;
}

const attributeToDisplayFn: Record<
Expand Down Expand Up @@ -530,10 +532,17 @@ const attributeToDisplayFn: Record<
if (isExpiredMarker(value)) return <ExpiredFieldBlock />;
return <DetailCard summary="Output">{JsonBlock(value)}</DetailCard>;
},
error: (value: unknown) => {
error: (value: unknown, context?: DisplayContext) => {
if (context?.resource === 'step' && context.status !== 'failed') {
return null;
}

const defaultOpen =
context?.resource === 'run' && context.status === 'failed';

if (isEncryptedMarker(value)) {
return (
<DetailCard summary="Error" defaultOpen>
<DetailCard summary="Error" defaultOpen={defaultOpen}>
<EncryptedFieldBlock />
</DetailCard>
);
Expand All @@ -545,14 +554,14 @@ const attributeToDisplayFn: Record<
// `{ message, stack }`. Render both with the dedicated error block.
if (isStructuredError(value)) {
return (
<DetailCard summary="Error" defaultOpen>
<DetailCard summary="Error" defaultOpen={defaultOpen}>
<ErrorStackBlock value={value} />
</DetailCard>
);
}

return (
<DetailCard summary="Error" defaultOpen>
<DetailCard summary="Error" defaultOpen={defaultOpen}>
{JsonBlock(value)}
</DetailCard>
);
Expand Down Expand Up @@ -816,8 +825,10 @@ export const AttributePanel = ({
const displayContext = useMemo(
() => ({
stepName: displayData.stepName as string | undefined,
resource,
status: displayData.status as string | undefined,
}),
[displayData.stepName]
[displayData.stepName, displayData.status, resource]
);
const handleCopyModuleSpecifier = useCallback((value: string) => {
navigator.clipboard
Expand Down
Loading