[enhanced builds] add build_machine_type option to project creation #319

marc-vercel · 2025-05-09T08:47:29Z

After the release of on-demand enhanced builds, we are adding support for this feature at the project level. We are adding a new option, build_machine_type, to the project.

Requisites of this feature:

The project option on_demand_concurrent_builds must be set to true. If it is set to false and build_machine_type is set to something, we should error.
It is optional (no need to set it, even if on_demand_concurrent_builds is set to true).
It can have two values: standard and enhanced.

Where does this feature reside?
It resides in Project settings > Build and Deployment > On-Demand Concurrent Builds

CURL Examples

Setting the build_machine_type to enhanced:

curl --request PATCH \
  --url https://api.vercel.com/v9/projects/<project_id>\
  --header 'Authorization: Bearer <token>' \
  --header 'Content-Type: application/json' \
  --data '{
  "resourceConfig": {
    "elasticConcurrencyEnabled": true,
    "buildMachineType": "enhanced"
  }
}'

Setting the build_machine_type to standard (notice that we send null instead of standard):

curl --request PATCH \
  --url https://api.vercel.com/v9/projects/<project_id>\
  --header 'Authorization: Bearer <token>' \
  --header 'Content-Type: application/json' \
  --data '{
  "resourceConfig": {
    "elasticConcurrencyEnabled": true,
    "buildMachineType": null
  }
}'

dglsparsons · 2025-05-09T08:49:20Z

client/project.go

 }

 type ResourceConfig struct {
 	FunctionDefaultMemoryType *string `json:"functionDefaultMemoryType,omitempty"`
 	FunctionDefaultTimeout    *int64  `json:"functionDefaultTimeout,omitempty"`
 	Fluid                     *bool   `json:"fluid,omitempty"`
 	ElasticConcurrencyEnabled *bool   `json:"elasticConcurrencyEnabled,omitempty"`
+	BuildMachineType          *string `json:"buildMachineType,omitempty"`


omitempty here means we'll never actually send null to the API. Probably want to remove that.

dglsparsons · 2025-05-09T08:49:56Z

vercel/data_source_project.go

+			"build_machine_type": schema.StringAttribute{
+				Description: "When `on_demand_concurrent_builds` is enabled, choose the build machine: `standard` (4 vCPU, 8 GB) or `enhanced` (8 vCPU, 16GB)",
+				Optional:    true,
+				Computed:    true,


I think we can add UseStateForUnknown, as this setting will never change based on the other settings changing, right?
Or does disabling on_demand_concurrent_builds affect this?

edit: i'm a fool, this is the data source.

dglsparsons · 2025-05-09T08:50:33Z

vercel/data_source_project.go

@@ -393,6 +393,14 @@ For more detailed information, please see the [Vercel documentation](https://ver
 				Optional:    true,
 				Computed:    true,
 			},
+			"build_machine_type": schema.StringAttribute{
+				Description: "When `on_demand_concurrent_builds` is enabled, choose the build machine: `standard` (4 vCPU, 8 GB) or `enhanced` (8 vCPU, 16GB)",
+				Optional:    true,


Shouldn't be optional on the data source. Only computed. (it's a read-only property here).

dglsparsons · 2025-05-09T08:50:42Z

vercel/data_source_project.go

+				Description: "When `on_demand_concurrent_builds` is enabled, choose the build machine: `standard` (4 vCPU, 8 GB) or `enhanced` (8 vCPU, 16GB)",
+				Optional:    true,
+				Computed:    true,
+				Validators: []validator.String{


No need for validators on the data source.

dglsparsons · 2025-05-09T08:51:24Z

vercel/resource_project.go

+				Validators: []validator.String{
+					stringvalidator.OneOf("standard", "enhanced"),
+				},
+				PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown()},


What happens if on_demand_concurrent_builds is disabled?

dglsparsons · 2025-05-09T08:51:57Z

vercel/resource_project.go

+				Description: "When `on_demand_concurrent_builds` is enabled, choose the build machine: `standard` (4 vCPU, 8 GB) or `enhanced` (8 vCPU, 16GB)",
+				Optional:    true,
+				Computed:    true,
+				Validators: []validator.String{


Let's figure out how to add a validator to make sure on_demand_concurrent_builds is enabled.

We have ModifyPlan on this resource - we can do it there.

dglsparsons · 2025-05-09T08:54:06Z

vercel/resource_project.go

@@ -1101,6 +1111,11 @@ func (r *ResourceConfig) toClientResourceConfig(onDemandConcurrentBuilds types.B
 	if !onDemandConcurrentBuilds.IsUnknown() {
 		resourceConfig.ElasticConcurrencyEnabled = onDemandConcurrentBuilds.ValueBoolPointer()
 	}
+	if !buildMachineType.IsUnknown() && *resourceConfig.ElasticConcurrencyEnabled {


What if resourceConfig.ElasticConcurrencyEnabled is null?

I don't think we need this logic here, we can just use a validator, and set buildMachineType without worrying about its relationship to elastic-concurrency.

dglsparsons · 2025-05-09T08:55:18Z

vercel/resource_project.go

+	if !buildMachineType.IsUnknown() && *resourceConfig.ElasticConcurrencyEnabled {
+		// `build_machine_type` can only be set when `on_demand_concurrent_builds`
+		// is enabled.
+		resourceConfig.BuildMachineType = buildMachineType.ValueStringPointer()


Don't forget to convert standard to a null pointer?

dglsparsons · 2025-05-09T08:55:59Z

vercel/resource_project.go

@@ -1472,6 +1487,7 @@ func convertResponseToProject(ctx context.Context, response client.ProjectRespon
 		ResourceConfig:                      resourceConfig,
 		NodeVersion:                         types.StringValue(response.NodeVersion),
 		OnDemandConcurrentBuilds:            types.BoolValue(response.ResourceConfig.ElasticConcurrencyEnabled),
+		BuildMachineType:           		 types.StringValue(*response.ResourceConfig.BuildMachineType),


Don't forget to convert null to standard? Also, dereferencing the pointer he could panic.

[enhanced builds] add build_machine_type option to project creation

55a4521

dglsparsons reviewed May 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[enhanced builds] add build_machine_type option to project creation #319

[enhanced builds] add build_machine_type option to project creation #319

Uh oh!

marc-vercel commented May 9, 2025 •

edited

Loading

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

dglsparsons May 9, 2025

Uh oh!

Uh oh!

[enhanced builds] add build_machine_type option to project creation #319

Are you sure you want to change the base?

[enhanced builds] add build_machine_type option to project creation #319

Uh oh!

Conversation

marc-vercel commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CURL Examples

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marc-vercel commented May 9, 2025 •

edited

Loading