fix(dev-overlay): add touch drag support for dev indicator (#96634) - #97044
Open
arts009009009 wants to merge 8 commits into
Open
fix(dev-overlay): add touch drag support for dev indicator (#96634)#97044arts009009009 wants to merge 8 commits into
arts009009009 wants to merge 8 commits into
Conversation
…ure cancellation Add back `touchAction: 'none'` to the Draggable wrapper to prevent touch gestures from being treated as viewport panning, which cancelled the drag and left the devtools indicator in a broken stuck state. Handle the `pointercancel` event so that when a drag gesture is cancelled (by the browser or OS), the indicator gracefully animates back to its previous corner instead of remaining stuck. Guard `releasePointerCapture` with `hasPointerCapture` to avoid errors when the pointer capture was already released by the browser. Adds a regression test verifying that `touchAction` is set to `'none'` on the draggable wrapper element. Fixes vercel#96634
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| type: 'string', | ||
| }, | ||
| { | ||
| type: 'object', |
Contributor
There was a problem hiding this comment.
Rewriting the no-html-link-for-pages options schema to an object-only shape breaks all existing configs that pass the custom pages directory as a string or array of strings, causing ESLint to throw a schema-validation error.
…dev-tools-indicator/draggable.tsx Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where the DevTools indicator in the error overlay could not be dragged properly on touch devices. The draggable component was freezing when attempting to move it via touch input.
Changes
draggable.tsxto handle touch events alongside mouse events.touchstart,touchmove, andtouchend.Reproduction
Notes
packages/next/src/next-devtools/dev-overlay/components/errors/dev-tools-indicator/draggable.tsx.Closes #96634