fix(eslint-plugin-next): export configs as data property for ESM compatibility - #97038
Open
arts009009009 wants to merge 6 commits into
Open
fix(eslint-plugin-next): export configs as data property for ESM compatibility#97038arts009009009 wants to merge 6 commits into
arts009009009 wants to merge 6 commits into
Conversation
…ure cancellation Add back `touchAction: 'none'` to the Draggable wrapper to prevent touch gestures from being treated as viewport panning, which cancelled the drag and left the devtools indicator in a broken stuck state. Handle the `pointercancel` event so that when a drag gesture is cancelled (by the browser or OS), the indicator gracefully animates back to its previous corner instead of remaining stuck. Guard `releasePointerCapture` with `hasPointerCapture` to avoid errors when the pointer capture was already released by the browser. Adds a regression test verifying that `touchAction` is set to `'none'` on the draggable wrapper element. Fixes vercel#96634
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro
Run:
node -e "import { configs } from '@next/eslint-plugin-next';"
Before
❌ SyntaxError: Named export 'configs' not found
After
✅ No error
Root Cause
Node’s ESM loader does not synthesize named exports from CommonJS getters.
The plugin was exporting configs via destructuring, which compiled to a getter.
Fix
Explicitly export configs as a data property and add CommonJS fallback.
Closes #86504