test: re-enable a few more passing NFT unit cases - #97017
Merged
mischnic merged 3 commits intoAug 11, 2026
Conversation
Enable the skipped cases in turbopack-tracing's unit.rs that pass as-is today, and document why a few of the remaining ones cannot pass with this harness. Verified by temporarily enabling all 84 skipped cases and running the suite (with and without the fixture workspace installed): 13 pass. The suite goes from 68 to 81 cases. Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
mischnic
changed the title
Contributor
Tests PassedCommit: 5d89922 |
Contributor
Stats from current PR🟢 1 improvement
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
Build Cache
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (4 files)Files with changes:
View diffspages-api-tu..ntime.dev.jsDiff too large to display pages-turbo...ntime.dev.jsDiff too large to display pages-api-tu..time.prod.jsDiff too large to display pages-turbo...time.prod.jsDiff too large to display 📎 Tarball URLCommit: 5d89922 |
…ions The Rust unit harness is a port of tests/node-file-trace/unit.test.js but ignored three things the JS harness passes, so some cases could never pass regardless of what Turbopack traced: - the `paths` mappings for the `esm-paths*` fixtures, now wired in as an import map - multiple entry points (`multi-input` traces four), now unioned - the `conditions` from a fixture's `test-opts.json`, now mapped onto `custom_conditions` (plus `browser` package-field remapping) Enables esm-paths, esm-paths-trailer and multi-input. browser-remappings-false and browser-remappings-string are disabled again: they only passed while their `browser` condition was ignored. With it honored, all browser-remappings cases fail for one shared reason, now documented: nft's reference output lists every candidate resolution (`main` next to the `exports`/`browser` target, and even a `browser` mapping disabled with `false`), while Turbopack only traces what it resolves to. Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
lukesandberg
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the skipped cases in turbopack-tracing's unit.rs that pass as-is today, and document why a few of the remaining ones cannot pass with this harness.