fix(next/routing): keep the hash out of the pathname and query of a destination - #97004
Draft
yogesh968 wants to merge 2 commits into
Draft
fix(next/routing): keep the hash out of the pathname and query of a destination#97004yogesh968 wants to merge 2 commits into
yogesh968 wants to merge 2 commits into
Conversation
…estination The destination was split on `?` and everything before it became the pathname, so a `#` was never recognised: - /new#section produced the pathname /new%23section - /new?ref=email#section produced the query value "email#section" Parse the destination with the URL constructor instead, which splits pathname, query and hash the way a browser does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
applyDestinationinpackages/next-routing/src/destination.tsmishandled a#in a routing destination. The fragment ended up inside the pathname, or inside a query value:/new#section→ pathname/new%23section/new?ref=email#section→ query valueref=email#sectionWhy?
The destination was split manually on
?, and everything before the first?was assigned straight tonewUrl.pathname. Nothing ever looked for#, so:path#hashstring became the pathname, and the URL setter percent-encoded the#into%23How?
Parse the destination with the
URLconstructor (relative to the current URL) instead of splitting on?. The parser splits pathname, query and hash the way a browser does, so the hash lands onnewUrl.hashand query values stay clean. Query merging is unchanged — the parsedsearchParamsare still copied onto the existing URL, overwriting on key collision.Tests added in
packages/next-routing/src/__tests__/redirects.test.tscovering a hash-only destination, hash + query, multiple?, and a destination with no hash (regression guard).