Skip to content

Conversation

lubieowoce
Copy link
Member

@lubieowoce lubieowoce commented Oct 17, 2025

If we're not going to be validating a prefetch (which is yet to be implemented), we don't to warm caches that aren't reachable in the static stage (i.e. in a static prerender).

Copy link
Member Author

lubieowoce commented Oct 17, 2025

Copy link
Contributor

Hi there 👋

It looks like this PR introduces broken links to the docs, please take a moment to fix them before merging:

Broken link Type File
/docs/app/getting-started/#middleware link /docs/01-app/03-api-reference/03-file-conventions/middleware.mdx
/docs/app/guides/self-hosting#proxy hash /docs/01-app/03-api-reference/03-file-conventions/proxy.mdx

Thank you 🙏

@lubieowoce lubieowoce changed the title label as Prefetch/Prefetchable depending on prefetch config [Cache Components] Only warm static caches if no runtime prefetch config Oct 17, 2025
@lubieowoce lubieowoce changed the title [Cache Components] Only warm static caches if no runtime prefetch config [CC] Less cache warming in dev if runtime prefetch not enabled Oct 17, 2025
@lubieowoce lubieowoce changed the title [CC] Less cache warming in dev if runtime prefetch not enabled [Cache Components] Less cache warming in dev if runtime prefetch not enabled Oct 17, 2025
@ijjk
Copy link
Member

ijjk commented Oct 17, 2025

Failing test suites

Commit: 997ac1e | About building and testing Next.js

pnpm test-start test/e2e/app-dir/app-prefetch/prefetching.test.ts

  • app dir - prefetching > should immediately render the loading state for a dynamic segment when fetched from higher up in the tree (DD)
Expand output

● app dir - prefetching › should immediately render the loading state for a dynamic segment when fetched from higher up in the tree

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  302 |   })
  303 |
> 304 |   it('should immediately render the loading state for a dynamic segment when fetched from higher up in the tree', async () => {
      |   ^
  305 |     let act: ReturnType<typeof createRouterAct>
  306 |     const browser = await next.browser('/', {
  307 |       beforePageLoad(page) {

  at it (e2e/app-dir/app-prefetch/prefetching.test.ts:304:3)
  at Object.describe (e2e/app-dir/app-prefetch/prefetching.test.ts:11:1)

pnpm test-dev test/e2e/app-dir/server-source-maps/server-source-maps.test.ts

  • app-dir - server source maps > sourcemaps errors during module evaluation (DD)
Expand output

● app-dir - server source maps › sourcemaps errors during module evaluation

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `app-dir - server source maps sourcemaps errors during module evaluation 1`

- Snapshot  - 2
+ Received  + 0

@@ -8,10 +8,8 @@
    "stack": [
      "eval app/module-evaluation/module.js (1:22)",
      "<FIXME-file-protocol>",
      "eval about:/Prerender/webpack-internal:///(rsc)/app/module-evaluation/page.js (5:65)",
      "<FIXME-file-protocol>",
-     "Function.all <anonymous>",
-     "Function.all <anonymous>",
      "Page <anonymous>",
    ],
  }

  510 |         `)
  511 |       } else {
> 512 |         await expect(browser).toDisplayCollapsedRedbox(`
      |                               ^
  513 |          {
  514 |            "description": "module-evaluation",
  515 |            "environmentLabel": "Prerender",

  at Object.toDisplayCollapsedRedbox (e2e/app-dir/server-source-maps/server-source-maps.test.ts:512:31)

pnpm test-start test/e2e/app-dir/segment-cache/search-params/segment-cache-search-params.test.ts

  • segment cache (search params) > when fetching with PPR, does not include search params in the cache key (DD)
Expand output

● segment cache (search params) › when fetching with PPR, does not include search params in the cache key

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  12 |   }
  13 |
> 14 |   it('when fetching with PPR, does not include search params in the cache key', async () => {
     |   ^
  15 |     let act: ReturnType<typeof createRouterAct>
  16 |     const browser = await next.browser('/search-params', {
  17 |       beforePageLoad(page) {

  at it (e2e/app-dir/segment-cache/search-params/segment-cache-search-params.test.ts:14:3)
  at Object.describe (e2e/app-dir/segment-cache/search-params/segment-cache-search-params.test.ts:5:1)

pnpm test-start test/e2e/app-dir/segment-cache/staleness/segment-cache-stale-time.test.ts

  • segment cache (staleness) > expires runtime prefetches when their stale time has elapsed (DD)
Expand output

● segment cache (staleness) › expires runtime prefetches when their stale time has elapsed

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  80 |   })
  81 |
> 82 |   it('expires runtime prefetches when their stale time has elapsed', async () => {
     |   ^
  83 |     let page: Playwright.Page
  84 |     const browser = await next.browser('/', {
  85 |       beforePageLoad(p: Playwright.Page) {

  at it (e2e/app-dir/segment-cache/staleness/segment-cache-stale-time.test.ts:82:3)
  at Object.describe (e2e/app-dir/segment-cache/staleness/segment-cache-stale-time.test.ts:5:1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants