Skip to content

chore: bump mini-css-extract-plugin version #81669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from

Conversation

mitchellrj
Copy link

@mitchellrj mitchellrj commented Jul 15, 2025

What?

  • Bumps mini-css-extract-plugin from 2.4.4 to 2.9.2.
  • Changelog

Why?

@ijjk
Copy link
Member

ijjk commented Jul 15, 2025

Allow CI Workflow Run

  • approve CI run for commit: 8cc69ae

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@mitchellrj mitchellrj force-pushed the chore/bump-mini-css-extract-plugin branch from af54608 to 8cc69ae Compare July 15, 2025 12:42
@TommyLeong
Copy link

hi @mitchellrj, maybe the file pnpm-lock.yaml should be deleted in order to overcome the build issue?

@Netail
Copy link
Contributor

Netail commented Jul 23, 2025

hi @mitchellrj, maybe the file pnpm-lock.yaml should be deleted in order to overcome the build issue?

Maintainers need to approve the CI to run

@@ -12020,8 +12020,8 @@ packages:
resolution: {integrity: sha512-I9jwMn07Sy/IwOj3zVkVik2JTvgpaykDZEigL6Rx6N9LbMywwUSMtxET+7lVoDLLd3O3IXwJwvuuns8UB/HeAg==}
engines: {node: '>=4'}

[email protected]:
resolution: {integrity: sha512-UJ+aNuFQaQaECu7AamlWOBLj2cJ6XSGU4zNiqXeZ7lZLe5VD0DoSPWFbWArXueo+6FZVbgHzpX9lUIaBIDLuYg==}
[email protected]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock file is inconsistent - it still references the old version 2.4.4 of mini-css-extract-plugin instead of the new version 2.9.2 that was updated in package.json.

View Details

Analysis

The package.json correctly updates mini-css-extract-plugin from version 2.4.4 to 2.9.2, and the lock file includes the new package definition for version 2.9.2 at line 12023. However, the dependency reference in the dependency tree (lines 1400-1401) still shows:

mini-css-extract-plugin:
  specifier: 2.4.4
  version: 2.4.4([email protected](@swc/[email protected](@swc/[email protected]))([email protected]))

This inconsistency means that despite updating the package.json, the application will still use the old version 2.4.4 instead of the intended 2.9.2. The lock file needs to be properly regenerated to reflect the package.json change.


Recommendation

Regenerate the lock file to ensure consistency with the package.json changes. This can typically be done by:

  1. Delete the existing pnpm-lock.yaml file
  2. Run pnpm install to regenerate the lock file with the correct version references

Alternatively, run pnpm update mini-css-extract-plugin to specifically update this dependency and synchronize the lock file.

The dependency reference should show:

mini-css-extract-plugin:
  specifier: 2.9.2
  version: 2.9.2([email protected](...))

👍 or 👎 to improve Vade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants