Skip to content

flag no-async-client-components for named exports too #79631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

kylemh
Copy link
Contributor

@kylemh kylemh commented May 26, 2025

Adding a feature

Fixes #77243

Currently, only default exports will be reported as errors against this lint rule, but named client components can still be exported and imported and break the spirit of this rule.

For Maintainers

  • Minimal description (aim for explaining to someone not on the team to understand the PR)
  • When linking to a Slack thread, you might want to share details of the conclusion
  • Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
  • Add review comments if necessary to explain to the reviewer the logic behind a change

What?

Why?

How?

Closes NEXT-
Fixes #77243

Copy link

changeset-bot bot commented May 26, 2025

⚠️ No Changeset found

Latest commit: 1552b69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ijjk
Copy link
Member

ijjk commented May 26, 2025

Allow CI Workflow Run

  • approve CI run for commit: 1552b69

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eslint rule no-async-client-component doesn't work
2 participants