Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ruby #48

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add support for ruby #48

wants to merge 5 commits into from

Conversation

styfle
Copy link
Member

@styfle styfle commented Jan 24, 2020 •
edited
Loading

This adds initial support for ruby using the system installed version (in PATH).

These are references:

@styfle
Copy link
Member Author

styfle commented Jan 24, 2020

@TooTallNate Something seems strange. The new test I added test_ruby_hello is never executed. Is there something I'm missing?

@styfle styfle mentioned this pull request Jan 25, 2020
Closed
@styfle styfle mentioned this pull request Mar 6, 2020
Closed
AndyBitz
AndyBitz reviewed Apr 2, 2020
View reviewed changes
Copy link
Contributor

@AndyBitz AndyBitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, but can't say much about the ruby part.

Will approve once the tests are green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyBitz AndyBitz AndyBitz left review comments

@TooTallNate TooTallNate Awaiting requested review from TooTallNate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@styfle @AndyBitz @TooTallNate