-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dep cleanup #110
dep cleanup #110
Conversation
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
Co-authored-by: Austin Merrick <[email protected]>
Co-authored-by: Austin Merrick <[email protected]>
Co-authored-by: Austin Merrick <[email protected]>
tests are failing, will fix in the meantime, is support for Node 16 still required or it could be dropped? asking because |
Thanks! Unfortunately, yes, Node 16 support is still required. |
patches/[email protected]
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to apply a patch to Vite because on node 16 getRandomValues is inside webcrypto and not require('crypto')
if (!("structuredClone" in globalThis)) { | ||
globalThis.structuredClone = structuredClone; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
polyfill because structuredClone
is only available since node 17
woohoo, all tests pass |
I think after pinning these deps and updating the lockfile, this is good to go. Thank you @talentlessguy! |
@onsclom done, the lockfile is updated and all deps have fixed versions |
@onsclom thank you for merging! any chance that it would also get published on npm? (bringing it up because it often happens that merged PRs remain unpublished) |
🎉 This PR is included in version 1.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@talentlessguy check out 1.1.3 and let us know if that doesn't work! |
Pulls in changes from: - vercel/fun#110 - vercel/fun#112 - vercel/fun#115 It's mostly updates from no longer needing node 16 support.
node:
protocol for better support in serverless environmentsI also had to replace Jest with Vitest because Jest kept using the ESM version of tinyexec and ignoring the CJS one (it's an issue with Jest, not tinyexec)
As a result, 23 dependencies are dropped and the package becomes ~20% smaller: