fix(amazon-bedrock): image conversion in tool use #5364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Continuing this work with your commits to track credit in #5390 |
|
Thank you for looking at the PR, and sorry for not adding tests - I was unsure if the current test suite was enough because I saw it already tested for images, but after looking at your PR I agree I should have. Will keep it in mind for the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5133.
This PR improves the handling of different content types in the
amazon-bedrockpackage when working with tool usage and the experimentaltoToolResultContentfunction.Specifically, the PR updates the logic that converts results to Bedrock messages by adding support for handling both text and image content.
Before this PR, as reported in the linked issue, this logic always assumed the result content was a text string and converted it to a JSON string, causing hallucinations.