AWS deployment fixes #308
Merged
AWS deployment fixes #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove trailing whitespace inadvertently left in the REAME.md for the AWS deployment. Signed-off-by: Sergei Trofimov <[email protected]>
env.{bash,zsh} gets sourced inside `make boostrap` to get the environment
variables set up. This happens before the venv exists (the boostrap
creates it).
Signed-off-by: Sergei Trofimov <[email protected]>
thomas-fossati
approved these changes
Mar 11, 2025
yogeshbdeshpande
approved these changes
Mar 11, 2025
- Add `packer init` call to bootstrap script to make sure packer plugins needed for building on AWS are installed after packer itself. - Update "AWS Credentials" section of the readme to point to packer configuration that describes how packer looks for AWS credentials, and add a sample way of configuring AWS creds in a way that packer can find them. Signed-off-by: Sergei Trofimov <[email protected]>
Fix command create-signing-key --> create-signer-key. (And ditto for the delete-). Signed-off-by: Sergei Trofimov <[email protected]>
Use deployment name as part of names of named objects in template stack to avoid name collision when multiple deployments are created on the same AWS account. Signed-off-by: Sergei Trofimov <[email protected]>
The service linked role for ElastiCache can only be created once per-account, and there does not appear to be a good way to do so conditionally inside the template, while also maintaining correct ordering. So, instead of specifying it in the template, check if it exists and create it if necessary before the stack. Signed-off-by: Sergei Trofimov <[email protected]>
Add -S flag to native deployment to force creation of systemd units in the deployment, regardless of the native system (there is also an equivalent -L for launchd). Use -S inside dep and rpm deployments to ensure that the packages are always created with systemd units even if the local system doesn't have systemd. Signed-off-by: Sergei Trofimov <[email protected]>
- Set GOOS=linux when creating deb and rpm to ensure that we're building for Linux even when doing so on a Mac. - Set GOARCH=amd64 when creating the deb for the AWS deployment, as EC2 instances used in the deployment are x86_64. Signed-off-by: Sergei Trofimov <[email protected]>
Add a command to add a pre-built deb package to the deployment rather than building one. Signed-off-by: Sergei Trofimov <[email protected]>
Do not rely on dns name being set in the environment when generating services config file. Instead, set it from the cached settings. Signed-off-by: Sergei Trofimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to create a parallel deployment (on an account that already has one) from a clean Arm-based enviroment identified a number issues with the AWS deployment automation that are being addressed here.