-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SEVSNP plugin for Veraison server #307
Open
jraman567
wants to merge
10
commits into
veraison:main
Choose a base branch
from
jraman567:sevsnp-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,743
−111
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f801532
fix(github): bump golang version to 1.24.1
jraman567 a6d97a3
feat(scheme): create plugin for AMD SEV-SNP
jraman567 497e1e8
feat(sevsnp): implement endorsement extractor
jraman567 e73fdff
feat(sevsnp): implement an endorsement handler
jraman567 b622454
feat(sevsnp): implement the store handler
jraman567 2b8c099
feat(scheme): implement evidence handler
jraman567 0af3e92
feat(sevsnp): get keys from evidence
jraman567 ef29b92
feat(sevsnp): validate integrity of evidence
jraman567 4c87309
feat(sevsnp): appraise the evidence
jraman567 94456b3
sevsnp tests: add unit tests
jraman567 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(scheme): create plugin for AMD SEV-SNP
define SEV-SNP scheme for Veraison. Switch to CoRIM version v1.1.3-0.20250307044607-0bbdd6c78526 Signed-off-by: Jagannathan Raman <[email protected]>
commit a6d97a3aa5cd93696253cada8fda562b3aa8ab3c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// Copyright 2025 Contributors to the Veraison project. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
package sevsnp | ||
|
||
const ( | ||
SchemeName = "SEVSNP" | ||
EndorsementMediaTypeRV = "application/corim-unsigned+cbor; profile=\"http://amd.com/2024/snp-corim-profile\"" | ||
// ToDo: check media type for AMD ARK | ||
EndorsementMediaTypeTA = "application/corim-unsigned+cbor; profile=\"https://amd.com/ark\"" | ||
EvidenceMediaType = "application/vnd.veraison.tsm-report+cbor" | ||
) | ||
|
||
var ( | ||
EndorsementMediaTypes = []string{ | ||
EndorsementMediaTypeRV, | ||
EndorsementMediaTypeTA, | ||
} | ||
|
||
EvidenceMediaTypes = []string{ | ||
EvidenceMediaType, | ||
} | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomas-fossati, I was referring to this during last week's meeting. SEVSNP profile says that the profile tag is
amd.com,2024:snp-corim-profile
. How do I convert this to URI?I would also appreciate your thoughts on EndorsementMediaTypeTA. Do I need to register somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag:amd.com,2024:snp-corim-profile
is already a URI (in fact, a "tag URI”), so you can use it as-is, no need to convert it: