Add a mock config-TSM sub-attester #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endpoint chares now gathers the output of GetEvidence() from each sub-attesters, combines them into a CMW collection, and wrap it as an EAT in its response. If there are multiple supported format available from a sub-attesters, ratsd core picks the first available format from GetSupportedFormats() Signed-off-by: Ian Chin Wang <[email protected]>
Add MockTSM attester as the wrapper of the faketsm from google/go-configfs-tsm repo to enable mock mode Signed-off-by: Ian Chin Wang <[email protected]>
Signed-off-by: Ian Chin Wang <[email protected]>
cowbon
requested review from
thomas-fossati,
deeglaze,
iolivergithub and
jraman567
as code owners
| ) | ||
|
|
||
| const ( | ||
| mediaType = "application/vnd.veraison.mock-tsm+json" |
There was a problem hiding this comment.
This should be the “usual” configfs-tsm media type.
The “provider” field in the JSON will be set to “fake” (or whatever) :-)
|
|
||
| outEncoded, err := out.ToJSON() | ||
| if err != nil { | ||
| errMsg := fmt.Errorf("failed to get mock TSM report: %v", err) |
There was a problem hiding this comment.
Suggested change
| errMsg := fmt.Errorf("failed to get mock TSM report: %v", err) | |
| errMsg := fmt.Errorf("failed to JSON encode mock TSM report: %v", err) |
| return getEvidenceError(errMsg) | ||
| } | ||
|
|
||
| if in.ContentType == mediaType { |
There was a problem hiding this comment.
We should avoid nesting long pieces of logic. Please invert the condition and fail early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26