Return meaningful EAT in chares #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowbon
requested review from
thomas-fossati,
deeglaze,
iolivergithub and
jraman567
as code owners
cowbon
force-pushed
the
mocktsm
branch
3 times, most recently
from
04f8b0c to
3ddb4a5
Compare
|
Thanks @thomas-fossati for your review, I've switched to |
Endpoint chares now gathers the output of GetEvidence() from each sub-attesters, combines them into a CMW collection, and wrap it as an EAT in its response. If there are multiple supported format available from a sub-attesters, ratsd core picks the first available format from GetSupportedFormats() Signed-off-by: Ian Chin Wang <[email protected]>
Signed-off-by: Ian Chin Wang <[email protected]>
|
|
||
| // Use a map until we finalize ratsd output format | ||
| eat := make(map[string]interface{}) | ||
| collection := cmw.NewCollection("tag:ietf.org,2025:ratsd") |
There was a problem hiding this comment.
Suggested change
| collection := cmw.NewCollection("tag:ietf.org,2025:ratsd") | |
| collection := cmw.NewCollection("tag:github.com,2025:veraison/ratsd/cmw") |
| return | ||
| } | ||
|
|
||
| for _, pn := range s.manager.GetPluginList() { |
There was a problem hiding this comment.
Suggested change
| for _, pn := range s.manager.GetPluginList() { | |
| for _, pn := range pl { |
|
|
||
| formatOut := attester.GetSupportedFormats() | ||
| if !formatOut.Status.Result || len(formatOut.Formats) == 0 { | ||
| errMsg := fmt.Sprintf("no supported formats from attester %s: %s ", |
There was a problem hiding this comment.
I think we should fail hard rather than soft here: we should either return the complete view of the sub-attesters or an error.
| s.reportProblem(w, p) | ||
| return | ||
| } | ||
| eat["cmw"] = serialized | ||
| w.Header().Set("Content-Type", respCt) |
There was a problem hiding this comment.
Since we are not yet signing the EAT, the correct media type is an UCS. See https://www.ietf.org/archive/id/draft-ietf-rats-eat-media-type-12.html#section-6.8 for the details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint chares now gathers the output of GetEvidence() from each sub-attesters, combines them into a CMW collection, and wrap it as an EAT in its response. If there are multiple supported format available from a sub-attester, ratsd core picks the first available format from GetSupportedFormats()