Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): correct services clone commands #55

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix(demo): correct services clone commands #55

merged 1 commit into from
Jul 11, 2024

Conversation

setrofim
Copy link
Contributor

In cca, correct the services clone command syntax to specify the tag using git's --branch option (which also works for tags); it was previously using golang syntax.

In psa, add --branch with the psa demo tag; previously, no ref was specified, so the latest would be cloned, potentially causing interop issues with other demo components.

Addresses #54

In cca, correct the services clone command syntax to specify the tag
using git's --branch option (which also works for tags); it was
previously using golang syntax.

In psa, add --branch with the psa demo tag; previously, no ref was
specified, so the latest would be cloned, potentially causing interop
issues with other demo components.

Signed-off-by: setrofim <[email protected]>
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yogeshbdeshpande yogeshbdeshpande merged commit e07aaa5 into main Jul 11, 2024
1 check passed
@yogeshbdeshpande yogeshbdeshpande deleted the fix branch July 11, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants