Assorted cleanups for lin_time.cpp #1056
Conversation
vincele
force-pushed
the
work_on_sleep_ready
branch
from
5c85577 to
a2facab
Compare
Signed-off-by: Vincent Legoll <[email protected]>
Assuming WIN32 & _WIN32 macros are equivalent, this code is duplicated. Signed-off-by: Vincent Legoll <[email protected]>
Signed-off-by: Vincent Legoll <[email protected]>
Signed-off-by: Vincent Legoll <[email protected]>
Signed-off-by: Vincent Legoll <[email protected]>
vincele
force-pushed
the
work_on_sleep_ready
branch
from
a2facab to
2eaf025
Compare
| reset_time_compression(s, a); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Q: is this disabling the games ability to Pause? Or is that being handled somewhere else now?
There was a problem hiding this comment.
This function is unused (AFAIK, I git grep'ed it in engine & assets), I think what is used is the toggle_pause() function, a few lines below in lin_time.cpp (used in engine/src/cmd/ai/firekeyboard.cpp).
There was a problem hiding this comment.
@vincele thanks - I'll try to pull it down and test to validate. That's my main concern here.
The only change that may affect WIN32 is the removal of the duplicated : #define & #include. I'd be strongly surprised if that had a runtime impact, as that would be very misleading from That being said, I'll still wait for an ACK from a WIN32 play test before merging. |
First easy batch of cleanups, there should be no issues with this fairly non-controversial lot.
Code Changes:
Issues:
Purpose: