Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some IRIX ifdeffery #1054

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vincele
Copy link
Contributor

@vincele vincele commented Mar 9, 2025

Intentionally not touching the other ones:

  • engine/src/endianness.h
  • engine/src/lin_time.cpp
  • engine/src/posh.h

As they are more involved, this is a first step in the right direction (hopefully)

Fixes: issue #995 (partly)

Code Changes:

  • Have the PR Validation Tests been run? compiles & run on linux/musl
  • This is a documentation change only

Issues:

  • Still some work to do after this first step

Purpose:

  • What is this pull request trying to do? Remove dead code
  • What release is this for? Next
  • Is there a project or milestone we should apply this to? Next

Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pretty good to go. We don't support IRIX... leaves me to wonder who used it in the past; but we don't now and even if we did we want to minimize this kind of thing too.

@stephengtuggy
Copy link
Contributor

Looks good so far. Just to double-check though, I would like to have someone test run the game on each of our three major supported platforms with these changes. (Windows, Linux, and macOS.)

Intentionally not touching the other ones:
- engine/src/endianness.h
- engine/src/lin_time.cpp
- engine/src/posh.h

As they are more involved

Fixes: issue vegastrike#995 (partly)
Signed-off-by: Vincent Legoll <[email protected]>
@royfalk
Copy link
Contributor

royfalk commented Mar 10, 2025

I went looking for glEnable( GL_SHARED_TEXTURE_PALETTE_EXT ) irix
and found another effort to revive the game from 10 years ago.

https://sourceforge.net/p/vegastrikevo/blog/2015/06/old-vegastrike-framework-inspection/

I glanced through and there may be some art and assets worth looking at.

Copy link
Contributor

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The glEnable( GL_SHARED_TEXTURE_PALETTE_EXT ); seems to also apply to other platforms. Something to keep in mind maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants