Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IRIX-specific code #995

Open
stephengtuggy opened this issue Jan 16, 2025 · 0 comments
Open

Remove IRIX-specific code #995

stephengtuggy opened this issue Jan 16, 2025 · 0 comments
Labels
enhancement help wanted
Milestone
0.10.x

Comments

@stephengtuggy
Copy link
Contributor 

          This whole file is archeological. We don't support IRIX. IRIX is dead (since 2006). SGI followed suit in 2009.

There are comments there made by the original devs about support only available in recent versions. I didn't check the blame but surely that was in 2001 or so. We can probably replace the whole thing with... nothing really.

Also, it wouldn't hurt to either tab those nested ifdefs or add a comment to the endif saying what it terminates.

None of this is your responsibility of course. You were there to touch the gl and glut includes.

Originally posted by @royfalk in #974 (comment)
@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Jan 22, 2025
vincele added a commit to vincele/Vega-Strike-Engine-Source that referenced this issue Mar 9, 2025
@vincele
Remove some IRIX ifdeffery
95462d4 
Intentionally not touching the other ones:
- engine/src/endianness.h
- engine/src/lin_time.cpp
- engine/src/posh.h

As they are more involved

Fixes: issue vegastrike#995 (partly)
vincele added a commit to vincele/Vega-Strike-Engine-Source that referenced this issue Mar 9, 2025
@vincele
Remove some IRIX ifdeffery
cfb3118 
Intentionally not touching the other ones:
- engine/src/endianness.h
- engine/src/lin_time.cpp
- engine/src/posh.h

As they are more involved

Fixes: issue vegastrike#995 (partly)
@vincele vincele mentioned this issue Mar 9, 2025
Open
2 tasks
vincele added a commit to vincele/Vega-Strike-Engine-Source that referenced this issue Mar 9, 2025
@vincele
Remove some IRIX ifdeffery
1a1c37d 
Intentionally not touching the other ones:
- engine/src/endianness.h
- engine/src/lin_time.cpp
- engine/src/posh.h

As they are more involved

Fixes: issue vegastrike#995 (partly)
Signed-off-by: Vincent Legoll <[email protected]>
vincele added a commit to vincele/Vega-Strike-Engine-Source that referenced this issue Mar 9, 2025
@vincele
Remove some IRIX ifdeffery
a45a0a5 
Intentionally not touching the other ones:
- engine/src/endianness.h
- engine/src/lin_time.cpp
- engine/src/posh.h

As they are more involved

Fixes: issue vegastrike#995 (partly)
Signed-off-by: Vincent Legoll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
0.10.x
Development

No branches or pull requests
2 participants
@BenjamenMeyer @stephengtuggy